Comment to 'Html language tag issue'
  • Hello

    1.1. You don't need to change module's name and uri.

    1.2. You already changed Name in sys_localization_languages table, therefore you need to do the same in install.sql file.

    1.3. - 1.5. Yes, you need to use 'en-us' everywhere if you reffer to Name field from sys_localization_languages table.

    1.6. Yes, you need to rename XML file to en-us.xml because such files should use the same value which is used in Name field from sys_localization_languages table.

    1.7. It's up to you. But I recommend you to change name attribute in resources tag for consistancy.

    2. 'table but nothing happened' where? 'The value of 'lang' in the HTML tag remains 'en'.' - where did you check this HTML tag?

    • @Anton L , You are amazing! Thanks a lot for your time and your guidance. You have no idea how helpful your answer is.

      I have just realized that I was doing things wrong and that would have affected how my site language works and also my site SEO. I will have to re-do my language module and change everything from "us" to "en-us". I am on my dev site testing things, so no problem about creating a new module.

      1.1. You said that I don't need to change module's name and uri.

      'name' => 'xxx_us',

      'home_uri' => 'us',

      Question: but as I am re-creating a new language with 'en-us', do I still need to keep them unchanged ('us')?

      home_uri is used to separate language like this: mysite.com/en, mysite.com/fr, etc right?

      2. As I said, for testing purposes, I changed the value of 'Name' to 'fr-fr', 'fr-ca', 'es-es' and 'es-mx' in the `sys_localization_languages` table of my English (US) module.

      Then, I cleaned the site cache and went to check the home page source code on my browser, but nothing happened. The value of 'lang' in the HTML tag remained 'en'. It didn't change to 'fr' or 'es'.

      My Question is: Creating new language modules for fr-fr, fr-ca, es-es and es-mx using the same rules and guidelines you provided to me, will the value of 'lang' in the HTML tag change to 'fr' or 'es' automatically?

      I am really worrying about the HTML lang tag as it's an important tag for SEO and the correct/valid way of using it, is with two-letter codes only (ISO language code).

      By the way, in /inc/classes/BxDolLanguages.php, i saw some functions 'en-us => en' etc. Are those functions the ones controlling the change from 'en-us' to 'en' in the HTML lang tag automatically? (just asking). Will it be necessary to write new functions to automatically change from 'fr-fr => fr' or fr-ca => fr' or 'es-es =>es' or es-mx =>es' or 'pt-pt =>pt' or 'pt-br => pt' etc?

      Thanks

      • Hi @Anton L . Please, any feedback to my reply above? I would need to sort out everything in my language file in order to go live. Thanks for your precious time.